✨ Upgrade scaffolds to use go 1.23 #4446
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
| @@ -25,7 +25,7 @@ jobs: | |||
| - name: Setup Go | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: '1.22' | |||
| go-version: '1.23' | |||
There was a problem hiding this comment.
would be better to use go-version-file: go.mod?
There was a problem hiding this comment.
Would you like to push a PR with this change?
Yes, that it would be better if work out in this case
There was a problem hiding this comment.
yes, can work on that next week
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
added
the
lgtm
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/skip pull-kubebuilder-e2e-k8s-1-32-0 not working yet |
camilamacedo86
merged commit a8e72c3
into
kubernetes-sigs:master
| go 1.22.0 | ||
| go 1.23.0 | ||
|
|
||
| godebug default=go1.23 |
There was a problem hiding this comment.
curious what does that do when you also have go 1.23.0 ?
There was a problem hiding this comment.
Why would we need to set the patch for debug?
if you think that should be changed, could you please raise a PR or issue with the suggestion and let us know more about the motivation?
There was a problem hiding this comment.
I should have clarified: I am asking why you added these godebug lines with the default that happens to exactly match the go version in the go line; my understanding is that is a "noop" but I'd love to learn why it isn't
(I am not talking about patchlevel at all)
Upgrade scaffolds from go version 1.22 to 1.23