-
Notifications
You must be signed in to change notification settings - Fork 1.6k
π Allow 'kubebuilder alpha generate' rescaffolds work with no longer supported/available plugins ( go/v3 and go/v2 ) #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @sarthaksarthak9. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great job π₯ π
I added some comments, and I think we need to add a test for this case.
Otherwise, it is all amazing !!!
@camilamacedo86 I noticed that updating the plugin list in getInitArgs() automatically updates the PROJECT file, even though I donβt explicitly see a save function. How is this happening? Could you help me confirm where the file update is triggered?. Also, is there still a need for updateProjectFileForAlphaGenerate() in this case? |
6805977
to
4461d1a
Compare
4461d1a
to
84cf6fd
Compare
84cf6fd
to
74ef8af
Compare
Thank you a lot for your contribution, but it's still not working. Following my latest test (done today):
Did you push all your changes? |
@camilamacedo86 Apologies for the oversight! I only had updated the description with the output earlier but forgot to push the changes. Changes are working I tested it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sarthaksarthak9,
Thank you so much for your contribution! I think something might be missing from your previous work because, when I tested your changes locally, it still didnβt work as expected.
What do you think about adding tests to ensure this scenario is automatically validated? See: #4572 (comment)
Looking forward to your thoughts!
Hi @sarthaksarthak9, Thank you so much for working on this fix! Also, I hope you donβt mind, but I updated the title because we use the emoji and description to generate the release notes. Since itβs a bug, I just tried to clarify it a bit better. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, sarthaksarthak9 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubebuilder-e2e-k8s-1-30-8 |
Fixes: #4433