🌱 (fix/enhance): correct GNU sed detection method for remove-spaces makefile target #4775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the trailing spaces removal in the Makefile. Previously, the script used the
uname
check to determine whether to use GNU or BSD sed syntax, which did not work well on macOS when GNU sed is installed.Now the script uses a check on
sed --version
for "GNU" to decide which sed syntax to apply. This ensures that, regardless of the OS, if GNU sed is available in the PATH, the GNU sed branch is used.