🐛 (helm/v1-alpha): Append project name to webhook service name

[fhirscher]

fixes: #4807

The Helm plugin scaffolding did not adjust the service name for conversion webhooks in the CRDs. This prevented the conversion webhook from being reached.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fhirscher (5e91ffe)

[k8s-ci-robot]

Welcome @fhirscher!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @fhirscher. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Hi @fhirscher

Thank you a lot for your contribution.

See that we are passing :

kubebuilder/pkg/plugins/optional/helm/v1alpha/scaffolds/init.go

Line 209 in bc78974

ServiceName: fmt.Sprintf("%s-webhook-service", s.config.GetProjectName()),

So, here we are updating the CRD with, it seems right 👍

However, the usage of 1 will result in update just the first one found, so I think need to be -1 instead . WDYT?

[fhirscher]

Hi @camilamacedo86

That's right. I can't find any unwanted effects when we use replaceAll().

[camilamacedo86]

Hi @fhirscher

Thank you a lot for your contribution 🥇

Please, my comment above and that for which we accept your contribution, you need to sign: #4808 (comment)

[fhirscher]

/easycla

[camilamacedo86]

/ok-to-test
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, fhirscher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment