-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 docs: fix make command and heading formatting in getting started guide #4811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs: fix make command and heading formatting in getting started guide #4811
Conversation
Welcome @Vaishnav88sk! |
Hi @Vaishnav88sk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
it shows make sense
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Vaishnav88sk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
fix: #4810
This PR makes two small documentation corrections in the getting started guide:
Replaces
make generate
withmake manifests
when explaining how to update RBAC files. The original command does not regenerate RBAC roles, which may confuse new users.Fixes a malformed heading by replacing backticks with a proper
tag for inline code formatting:
From:
`ownerRef` and cascading event
To:
ownerRef
and Cascading EventsThese changes improve clarity and formatting consistency for readers following the tutorial.