Skip to content

Manual cherry pick of #4870 add feature gate to control cohort controller #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sohankunkerkar
Copy link
Member

Cherry pick of #4870 on release-0.11.

Allow one to disable cohorts via a HiearachialCohort feature gate

@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Apr 8, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from gabesaba and mimowo April 8, 2025 19:56
Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 09825be
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67f58edd73828c00080e334e
😎 Deploy Preview https://deploy-preview-4913--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2025
@kannon92
Copy link
Contributor

kannon92 commented Apr 8, 2025

/lgtm

/assign @mimowo @tenzen-y

I hope we can consider cherry-picking this one.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5506a13a4b1df1cd386c8b4c0171207049d6208

Copy link

linux-foundation-easycla bot commented Apr 8, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kannon92 / name: Kevin Hannon (09825be)

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 8, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2025
@sohankunkerkar sohankunkerkar force-pushed the release-0.11 branch 2 times, most recently from ec3e8b5 to 09825be Compare April 8, 2025 21:02
@k8s-ci-robot k8s-ci-robot removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 8, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 8, 2025
@kannon92
Copy link
Contributor

kannon92 commented Apr 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5506a13a4b1df1cd386c8b4c0171207049d6208

@mimowo
Copy link
Contributor

mimowo commented Apr 9, 2025

/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit cdee4f1 into kubernetes-sigs:release-0.11 Apr 9, 2025
19 checks passed
sohankunkerkar added a commit to sohankunkerkar/kueue that referenced this pull request Apr 10, 2025
@mimowo
Copy link
Contributor

mimowo commented Apr 16, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants