Skip to content

Automated cherry pick of #4824: Fix getAncestorWorkload if integration disabled. #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 10, 2025
Merged

Automated cherry pick of #4824: Fix getAncestorWorkload if integration disabled. #4924

merged 6 commits into from
Apr 10, 2025

Conversation

mbobrovskyi
Copy link
Contributor

Cherry pick of #4824 on release-0.11.

#4824: Fix getAncestorWorkload if integration disabled.

For details on the cherry pick process, see the cherry pick requests page.

Fixed a bug that caused Kueue to create redundant workloads for each Job when manageJobsWithoutQueueName was enabled, JobSet integration was disabled, and AppWrapper was used for JobSet.

@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Apr 10, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 10, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 10, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 01fd938
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67f7ebee7bcabf0008e55337
😎 Deploy Preview https://deploy-preview-4924--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi mbobrovskyi mentioned this pull request Apr 10, 2025
Closed
@mimowo
Copy link
Contributor

mimowo commented Apr 10, 2025

/lgtm
/approve assuming the tests pass

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7005f2677b17628bd86c188683e3533413cc656

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit ff6c2ad into kubernetes-sigs:release-0.11 Apr 10, 2025
19 checks passed
@mimowo
Copy link
Contributor

mimowo commented Apr 16, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@mbobrovskyi @mimowo @k8s-ci-robot