Skip to content

Automated cherry pick of #4808: Fix LeaderWorkerSet with manageJobsWithoutQueueName. #4936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mbobrovskyi
Copy link
Contributor

Cherry pick of #4808 on release-0.11.

#4808: Fix LeaderWorkerSet with manageJobsWithoutQueueName.

For details on the cherry pick process, see the cherry pick requests page.

Fix bug which prevented using LeaderWorkerSet with manageJobsWithoutQueueName enabled. In particular, Kueue would create redundant workloads for each Pod, resulting in worker Pods suspended, while the leader Pods could bypass quota checks.

@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Apr 11, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 11, 2025
Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 8b1a961
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67f94b39a9ba6400083aa29c

@mbobrovskyi
Copy link
Contributor Author

/assign @mimowo

@mimowo
Copy link
Contributor

mimowo commented Apr 11, 2025

/lgtm
/approve
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f113e660511d71dc6ac5e5301cc23b7f6608ea2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@mbobrovskyi mbobrovskyi force-pushed the automated-cherry-pick-of-#4808-upstream-release-0.11 branch from 048d42e to 8b1a961 Compare April 11, 2025 17:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mimowo April 11, 2025 17:02
@mimowo
Copy link
Contributor

mimowo commented Apr 11, 2025

/lgtm
assuming these are only left places

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8f53aaeb09d6da7d6486287cc8edc6460f37063a

@k8s-ci-robot k8s-ci-robot merged commit 4cd3b92 into kubernetes-sigs:release-0.11 Apr 11, 2025
19 checks passed
@mbobrovskyi mbobrovskyi deleted the automated-cherry-pick-of-#4808-upstream-release-0.11 branch April 11, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants