Skip to content

[release-0.11] Protect GuaranteedQuota When FairSharing Weight=0 #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

[release-0.11] Protect GuaranteedQuota When FairSharing Weight=0 #4980

merged 1 commit into from
Apr 15, 2025

Conversation

k8s-infra-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #4962

/assign tenzen-y

Fix bug where Cohorts with FairWeight set to 0 could have workloads running within Nominal Quota preempted

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 15, 2025
Merged
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 15, 2025
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Apr 15, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 6af03d7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67fe48ce819bf40008d6446e
😎 Deploy Preview https://deploy-preview-4980--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo
Copy link
Contributor

mimowo commented Apr 15, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eccb5a97c8de9038cecda023619bb7392d77e2c7

@k8s-ci-robot k8s-ci-robot merged commit ce022ec into kubernetes-sigs:release-0.11 Apr 15, 2025
19 checks passed
@mimowo
Copy link
Contributor

mimowo commented Apr 16, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabesaba gabesaba Awaiting requested review from gabesaba

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @mimowo @k8s-ci-robot @tenzen-y @gabesaba