Add kustomize rule for commonAnnotations on CRD #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
marquiz
reviewed
Apr 16, 2021
I think I was short on explanation on this PR , going to edit the description |
Currently `mkae manifests` resets the CRD file removing a needed annotation - api-approved.kubernetes.io: "unapproved, experimental-only" this patch overrides this autogeneration by adding a kustomize rule commonAnnotations into config/crd/kustomization.yaml file, allowing kustomize to patch the crd when `kustomize build config/default` is called, injecting the annotation. Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
devel/customannotation_crd
branch
from
806ec9b to
369c782
Compare
marquiz
reviewed
Apr 16, 2021
| @@ -5,7 +5,6 @@ kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.4.1 | |||
| api-approved.kubernetes.io: "unapproved, experimental-only" | |||
There was a problem hiding this comment.
yes, is not needed any more, we can now host the default yaml we get from make manifest and count on kustomize to apply annotation when make deploy
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
make manifestsresets the CRD file removing a neededannotation
this patch overrides this autogeneration by adding a kustomize rule commonAnnotations into
config/crd/kustomization.yaml file, allowing kustomize to patch the crd
when
kustomize build config/defaultis called, injecting theannotation.
Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]