-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix toolbox addons apply command #17429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @tanelmae! |
Hi @tanelmae. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I forgot to update the docs earlier. Done now |
no worries 🙂 |
Thank you for fixing this @tanelmae . I had a look and I'm not quite sure how/if this ever worked, I was expecting two PRs to have "crossed" during merge, but that didn't happen AFAICT. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently, when running
kops toolbox addons apply <some-channel>
user is instructed to supply non-supported flagMust specify --yes to update
.This change will allow to use the command the same way as in
channels/pkg/cmd/apply_channel.go
.