Skip to content

node-controller: deflake TestUpdateNodeWithMultiplePods #45100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2017
Merged

node-controller: deflake TestUpdateNodeWithMultiplePods #45100

merged 1 commit into from
May 2, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Apr 28, 2017 •
edited
Loading

Use absolute time and increase grace duration to 500ms for tests under load.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2017
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2017
@gmarek
Copy link
Contributor

gmarek commented Apr 28, 2017 •
edited
Loading

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, sttts

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Apr 28, 2017
@gmarek gmarek added release-note-none Denotes a PR that doesn't merit a release note. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Apr 28, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2017
@sttts
Copy link
Contributor Author

sttts commented Apr 28, 2017

@k8s-bot unit test this

@gmarek
Copy link
Contributor

gmarek commented Apr 28, 2017

@sttts - I believe unit tests are currently broken.

@gmarek
Copy link
Contributor

gmarek commented Apr 29, 2017

@k8s-bot unit test this

@sttts
node-controller: deflake TestUpdateNodeWithMultiplePods
a426adc 
Use absolute time and increase grace duration to 500ms for tests under load.
@sttts sttts force-pushed the sttts-deflake-TestUpdateNodeWithMultiplePods branch from 1926b7f to a426adc Compare May 2, 2017 06:01
@sttts sttts added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 2, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 2, 2017 •
edited
Loading

@sttts: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins unit/integration a426adc link @k8s-bot unit test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45100, 45152, 42513, 44796, 45222)

@k8s-github-robot k8s-github-robot merged commit 44d5bf2 into kubernetes:master May 2, 2017
@diegs diegs mentioned this pull request Jun 16, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 19, 2017
Merge pull request #47680 from diegs/automated-cherry-pick-of-#45100-…
82671e2 
…origin-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #45100

Cherry pick of #45100 on release-1.6.

#45100: node-controller: deflake TestUpdateNodeWithMultiplePods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

@aveshagarwal aveshagarwal

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sttts @k8s-reviewable @gmarek @k8s-github-robot @k8s-ci-robot @aveshagarwal @ingvagabund