apiserver: injectable default watch cache size #45403
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
size/M
|
This change is |
sttts
force-pushed
the
sttts-tri-state-watch-capacity
branch
from
87ad473 to
f78fdf9
Compare
sttts
changed the title
sttts
added
release-note-none
sttts
force-pushed
the
sttts-tri-state-watch-capacity
branch
from
f78fdf9 to
d59b027
Compare
| // Storage is non-nil. | ||
| WatchCacheSize int | ||
| // This value is ignored if Storage is non-nil. Nil is replaced with a default value. | ||
| // A zero integer will disable caching. |
There was a problem hiding this comment.
above you're testing for > 0, not >= 0, so I think zero currently does defaultWatchCacheSize
There was a problem hiding this comment.
Good spot. >=0 (= off) is correct.
|
one comment, then lgtm |
sttts
force-pushed
the
sttts-tri-state-watch-capacity
branch
from
d59b027 to
4ebc578
Compare
k8s-github-robot
added
kind/old-docs
size/L
sttts
force-pushed
the
sttts-tri-state-watch-capacity
branch
from
4ebc578 to
00f2690
Compare
sttts
changed the title
|
@deads2k ptal. I added a possibility to inject the default value via EtcdOptions. IMO this is much cleaner than wrapping the default decorator. |
| @@ -40,7 +40,7 @@ func NewREST(optsGetter generic.RESTOptionsGetter) *REST { | |||
| } | |||
|
|
|||
| // We explicitly do NOT do any decoration here yet. // TODO determine why we do not want to cache here | |||
| opts.Decorator = generic.UndecoratedStorage // TODO use watchCacheSize=-1 to signal UndecoratedStorage | |||
| opts.Decorator = generic.UndecoratedStorage | |||
There was a problem hiding this comment.
Don't we want a better way to use undecorated other than directly specifying it? @liggitt I forget exactly how we wanted to do it when I refactored this code originally.
sttts
force-pushed
the
sttts-tri-state-watch-capacity
branch
from
00f2690 to
59833a8
Compare
sttts
force-pushed
the
sttts-tri-state-watch-capacity
branch
from
59833a8 to
b799e62
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k, sttts Assign the PR to them by writing
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@smarterclayton approved? |
deads2k
added
the
approved
|
api extensions again. approved. Pull to add owners here: #45490 |
|
Automatic merge from submit-queue |
This makes it possible to override the default watch capacity in the REST options getter. Before this PR the default is written into the storage struct explicitly, and if it is the default, the REST options getter didn't know. With this the PR the default is applied late and can be injected from the outside.