-
Notifications
You must be signed in to change notification settings - Fork 40.6k
orphan when kubectl delete --cascade=false #45661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, kargakis
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@deads2k: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue |
Removing label |
Automatic merge from submit-queue [1.6] orphan when kubectl delete --cascade=false Cherry-pick of #45661 ```release-note Fix `kubectl delete --cascade=false` for resources that don't have legacy overrides to orphan by default. ```
The default for new objects is to propagate deletes (use GC) when no deleteoptions are passed. In addition, the vast majority of kube objects use this default. Only a few controllers resources (sts, rc, deploy, jobs, rs) orphan by default. This means that when you do
kubectl delete sa/foo --cascade=false
you do not orphan. That doesn't fulfill the intent of the command. This explicitly orphans when--cascade=false
so we don't use GC.@fabianofranz
@jwforres I liked this easter egg :)
@kubernetes/sig-cli-bugs we should backport this to 1.6