Skip to content

Create a separate group with etcd admin access #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

serathius
Copy link
Contributor

I'm working on Antithesis integration as proposed in etcd-io/etcd#19299.

We would like to setup a github workflow that calls a third party service with credentials. This should be doable by setting up a secret in github actions as described in https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions. At the moment no etcd maintainer has permissions to do that.

I get permission I copied the the etcd-operator-admins group and I would like to give admin access to SIG etcd leads.
Can be temporary just for the secret setup.

/cc @ahrtr @jmhbnz @ivanvc @wenjiaswe

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2025
@ahrtr
Copy link
Member

ahrtr commented Apr 9, 2025

/lgtm
/approve

Can be temporary just for the secret setup.

Do you mean the team etcd-admins will be removed once it isn't needed anymore (e.g. after the secret setup is done)?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7a5130 into kubernetes:main Apr 9, 2025
4 checks passed
@ahrtr
Copy link
Member

ahrtr commented Apr 9, 2025

Oh, I should hold the PR until other maintainers review :(

@jmhbnz
Copy link
Member

jmhbnz commented Apr 9, 2025

Just a note to confirm it is intentional that from a day to day perspective we operate without admin privilege on repositories.

When situations like this pop up where we require admin we historically have just temporarily bumped the permissions for maintainers-etcd group to move it from maintain ---> admin and then revert the commit once neccessary changes are complete. Example is: #5360

No issues with this pr - let's just revert the new group once any necessary changes to enable Antithesis integration have wrapped up and return to our least privilege operating principle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants