Skip to content

prow: approve: our robot can approve PRs? #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevekuznetsov opened this issue Nov 29, 2017 · 1 comment · Fixed by #5730
Closed

prow: approve: our robot can approve PRs? #5719

stevekuznetsov opened this issue Nov 29, 2017 · 1 comment · Fixed by #5730
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug.

Comments

@stevekuznetsov
Copy link
Contributor

We recently moved to the assign/approve/blunderbuss trio of Prow plugins in our cluster and we're seeing our robot considered a valid approver for a PR like so: openshift/origin#17350 (comment)

[APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/openshift/origin/pull/17350#issuecomment-347988758" title="LGTM">openshift-merge-robot</a>*, *<a href="https://github.com/openshift/origin/pull/17350#" title="Author self-approved">rootfs</a>*, *<a href="https://github.com/openshift/origin/pull/17350#issuecomment-348004549" title="LGTM">stevekuznetsov</a>*

The full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).

<details >
Needs approval from an approver in each of these OWNERS Files:

- ~~[images/base/OWNERS](https://github.com/openshift/origin/blob/master/images/base/OWNERS)~~ [stevekuznetsov]

You can indicate your approval by writing `/approve` in a comment
You can cancel your approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->

/area prow
/kind bug
/cc @Kargakis @cjwagner

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. labels Nov 29, 2017
@cjwagner
Copy link
Member

I believe this is an interaction with the lgtm-after-commit-munger which comments with /lgtm cancel //PR changed after LGTM, removing LGTM...
The approve plugin considers this an approval because where it expects the argument cancel it finds cancel //PR changed after LGTM, removing LGTM....

I think the best fix is to change the approve plugin to check that the argument to the /lgtm command contains cancel instead of checking for strict equality. I'll make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants