Skip to content

Fix lgtm removal considered as approval. #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

Fix lgtm removal considered as approval. #5730

merged 1 commit into from
Nov 30, 2017

Conversation

cjwagner
Copy link
Member

fixes #5719

I also added the @openshift-merge-robot as a deprecated bot name so that old approval notifications will be deleted appropriately and so that approve label applications from @openshift-merge-robot are not considered to be human made approvals.

/cc @stevekuznetsov

@cjwagner cjwagner requested a review from 0xmichalis as a code owner November 30, 2017 01:29
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2017
@cjwagner cjwagner added the area/prow Issues or PRs related to prow label Nov 30, 2017
@cjwagner cjwagner force-pushed the the-bots-are-teasing-us branch from 6bcae47 to c778e0e Compare November 30, 2017 01:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2017
stevekuznetsov
stevekuznetsov approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for picking this up so quickly!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, stevekuznetsov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d4a5668 into kubernetes:master Nov 30, 2017
@cjwagner cjwagner deleted the the-bots-are-teasing-us branch November 30, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@0xmichalis 0xmichalis Awaiting requested review from 0xmichalis

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prow: approve: our robot can approve PRs?
3 participants
@cjwagner @k8s-ci-robot @stevekuznetsov