Used gzdecode() instead of gzinflate() for better compatibility. #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Berthereau <[email protected]>
Daniel-KM
pushed a commit
to Daniel-KM/Omeka-S-module-SingleSignOn
that referenced
this pull request
May 2, 2025
|
Makes sense. gzip magic bytes header or checksum are probably getting in the way and are not understood by the |
|
@Daniel-KM @Xerkus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the http response is gzipped, the uncompression process should use
gzdecode(), that manages more encoding subtilities in headers thangzinflate().The url i tried is https://pub.federation.renater.fr/metadata/test/preview/preview-idps-test-metadata.xml, that is gzipped when the laminas http client allows it, but gzinflate() cannot uncompress it. gzdecode() works with any other urls that is http gzipped.