Skip to content

Update and simplify Oracle Database example cookbook #31364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

cjbj
Copy link
Contributor

@cjbj cjbj commented May 27, 2025

Thank you for contributing to LangChain!

  • PR title: "langchain: cookbook"

  • Description: Update the Oracle Database sample cookbook sample code and text.

  • Add tests and docs: not applicable.

  • Lint and test: Linted

Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 27, 2025 6:52am

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 27, 2025
@cjbj
Copy link
Contributor Author

cjbj commented May 27, 2025

@skmishraoracle please review this.

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label May 27, 2025
@eyurtsev eyurtsev self-assigned this Jun 5, 2025
@eyurtsev
Copy link
Collaborator

eyurtsev commented Jun 5, 2025

@cjbj assuming we're waiting on a review from @skmishraoracle ?

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 5, 2025
@cjbj
Copy link
Contributor Author

cjbj commented Jun 18, 2025

@eyurtsev we don't need to wait for @skmishraoracle

@ccurme ccurme merged commit b6f74bf into langchain-ai:master Jun 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants