feat(Form Component): handle boolean types & adjust migrations per mark #45 #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmonshi
requested changes
Jun 4, 2025
| */ | ||
| protected array | Arrayable | Closure | null $colors = null; |
There was a problem hiding this comment.
these were from filament, to account for any scenario.
I think allowing Closures is a good idea
| */ | ||
| protected array | Closure | null $selectedIcons = null; |
There was a problem hiding this comment.
I think also better to allow at least Closure
Understandable, but do you have in mind any real use case for it ? I prefer to handle use cases as needed, and we can handle closures anytime later without breaking changes. |
set the color based on the current tenant from its profile! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.