Skip to content

Js update #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Js update #9

wants to merge 11 commits into from

Conversation

Matt-Eva
Copy link

No description provided.

@Matt-Eva Matt-Eva requested a review from lizbur10 May 30, 2023 19:32
Copy link
Contributor

@lizbur10 lizbur10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

page, you'll see a **Resources** section that lists one resource: `/articles`.
The server has read the `db.json` file and found our `articles` key, turning it
into a resource. Click `/articles` and you will be navigated to a new page,
> **Note:** If you see an error saying something like `EADDRESSINUSE`, that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this note come after the paragraph below it instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does seem like a better place for it. Changed!

README.md Outdated
`25.666 ms` is the amount of time it took to complete the request, in
milliseconds. Back in Postman, we can see the response from our server in the
lower panel and confirm we received what we expected.
JSON Server sees that this is a GET request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest combining this line with the paragraph below

@lizbur10 lizbur10 requested a review from ChelseaLrn September 20, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants