Tune up webpacker #126
Merged
Tune up webpacker #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new `lcms_engine_javascript_pack_tag` method to be used to include(and compile) lcms-engine based packs. This is a solution to be able to isolate project specific packs and packs created inside the gem. As an alternative we could use the solution provided here - rails/webpacker#348 (comment) This looks more reliable to me. - Update Dockerfile to set explicitly locale. - Update gems to the latest versions
paranoicsan
force-pushed
the
webpacker-tune-up
branch
from
61f7ae2 to
c0913c1
Compare
shlag3n
approved these changes
Jun 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new
lcms_engine_javascript_pack_tagmethod to be used to include(and compile) lcms-engine based packs.This is a solution to be able to isolate project-specific packs and packs created inside the gem.
As an alternative, we could use the solution provided here. This looks more reliable to me.