-
Notifications
You must be signed in to change notification settings - Fork 2.2k
SD Card Value Logger Enable #2700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You have to enable it in the code by defining I hope to have it able to compile again in a few days. |
Thanks for the response. I had found some of the SD card lines in the code (and tried some of the earlier file changes) and tried to compile a few times without any success. Looking forward to testing out the fix! I'm working on a NodeMCU/SDS011 mass deployment to solve some air quality issues where wifi is not completely stable. ESP Easy and NodeMCU fits my needs in every other aspect. |
@Misiu I have already changed a lot of code to make it compile again, but there are still parts left which make it not compile. |
I can now compile it, with SD card support, but it will not be useful. I opened an issue about it: esp8266/Arduino#6767 |
what happeneds if you just enable includes for sd card libraries without use it in runtime? |
Exactly the same as when I enable
Good idea by the way. |
so something is in includes that break build, you can try to move these includes on the top test one more time, |
On the top where? |
of all includes |
So place it in ESPEasy.ino file at the top? |
With only the include of
|
and any compiler warnings? |
Nope |
hope it is not one more time pio build issue. @clumsy-stefan maybe you can try this on arduino ide? |
I will create a commit for the changes needed to actually compile it. |
Can try the commits tomorrow. |
However it is unusable, see esp8266/Arduino#6767
@clumsy-stefan is it possible for you to paste here first and last 10 lines (they are very long) of build log from arduino ide? |
tried to compile with commit ff3cac9 but it fails to compile with:
Did not further analy/test yet though... |
The same build error, so that's good :) |
Thats's why I love IT... It's fails, so it's good.... That's why nobody else understands what we do.. Binary logic rocks 😃 |
Yep, there are only 10 kinds of people ;) |
@clumsy-stefan and what about build log? |
except the lines what it's compiling what I posted above is the only interesting part... more details only when sucessfully compiled.. |
so please disable Feature_sd to have successfull build log |
hmm.. what information are you looking for? There is nothing in there except which files it compiles (~50-100 lines) and where it fails (which it doesn't if succesfully compiled).
|
need specialy first lines like these with -dump-prefs and -compile |
There you go:
But that's different for the various boards I use... |
@clumsy-stefan thanks i will try to build with arduino-builder :) |
I just tested it and the custom build does allow me to build a version with the |
…it#2700 ) Fixes: letscontrolit#2700 This does make sure we build more often with `FEATURE_SD` and `FEATURE_MDNS` enabled.
Last night I made a ESPEasy_mega-20191130-17-PR_2798.zip test build. |
[FEATURE_SD] Add build in Platformio.ini with SD enabled (#2700 )
Release mega-20191208 Changes in mega-20191208 (since mega-20191130): Gijs Noorlander (17): [WiFi] Use last known BSSID & channel from RTC + MQTT fixes [PIO] Update to core 2.6.2 [WiFi] Improve ESP32 WiFi connect + fix mDNS updates [PIO] Fix build failure due to incorrect flags. [PIO] Don't use Python 3 specific since Travis still uses Python 2.7 [WiFi] Call WiFi disconnect in setup() (letscontrolit#2757) [Rules] Parse template for all command calls [Rules] Execute some events asynchronous [Commands] Proper error logs when processing commands. [Commands] Add flag to be a bit more tolerant in last argument parsing [Events] Run events from rules immediately + add AsyncEvent command [FEATURE_SD] Add build in Platformio.ini with SD enabled (letscontrolit#2700 ) [Rules] Add some checks for rules consistency before saving [Rules] Add check for correct received POST data when saving rules [JSON] Fix issues with generated JSON [JSON] Fix non valid timing stats json when no plugins defined (letscontrolit#2767) [JSON] Extend timing stats JSON end point with controller and misc stats TD-er (1): automatically updated release notes for mega-20191208 stefan (1): Fix Arduino IDE include path
How do I enable this in ESPEasy-mega-20191028? I have an SD connected up to NodeMCU SPI but the "SD Card Value Logger" is not available (not even visible). Any help would be greatly appreciated.
Originally posted by @Droscovi in #429 (comment)
The text was updated successfully, but these errors were encountered: