You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.
The action failed due to multiple Playwright test failures in the Mobile Safari browser: • Visual regression test (VRT) failed: Screenshot comparison for 'top' test timed out after 5000ms and showed 2335 pixel differences (0.01 ratio) in file tests/vrt/vrt.test.ts:21:22 • Two E2E tests failed due to timeouts: - "Edge animation should be triggered when table node is clicked" - element not found at tests/e2e/page.test.ts:53:34 - "Cardinality should be highlighted when table node is clicked" - test timeout exceeded All tests failed after multiple retries, indicating consistent issues with the Mobile Safari browser environment or application behavior.
Relevant error logs:
1: ##[group]Runner Image Provisioner2: Hosted Compute Agent
...
219: Progress: resolved 2082, reused 0, downloaded 567, added 550220: Progress: resolved 2082, reused 0, downloaded 586, added 558221: Progress: resolved 2082, reused 0, downloaded 694, added 680222: Progress: resolved 2082, reused 0, downloaded 842, added 811223: Progress: resolved 2082, reused 0, downloaded 933, added 899224: Progress: resolved 2082, reused 0, downloaded 1154, added 1168225: Progress: resolved 2082, reused 0, downloaded 1283, added 1250226: Packages are hard linked from the content-addressable store to the virtual store.227: Content-addressable store is at: /home/runner/setup-pnpm/node_modules/.bin/store/v10228: Virtual store is at: node_modules/.pnpm229: Progress: resolved 2082, reused 0, downloaded 1407, added 1395230: Progress: resolved 2082, reused 0, downloaded 1646, added 1664231: Progress: resolved 2082, reused 0, downloaded 1833, added 1845232: Progress: resolved 2082, reused 0, downloaded 1960, added 1963233: Progress: resolved 2082, reused 0, downloaded 2062, added 2082, done234: WARN Failed to create bin at /home/runner/work/liam/liam/node_modules/.pnpm/node_modules/.bin/supabase. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/node_modules/.pnpm/node_modules/supabase/bin/supabase'235: WARN Failed to create bin at /home/runner/work/liam/liam/node_modules/.pnpm/[email protected]/node_modules/supabase/node_modules/.bin/supabase. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/node_modules/.pnpm/[email protected]/node_modules/supabase/bin/supabase'236: .../node_modules/supabase postinstall$ node scripts/postinstall.js237: .../node_modules/supabase postinstall: Downloading https://github.com/supabase/cli/releases/download/v2.24.3/supabase_2.24.3_checksums.txt238: .../node_modules/supabase postinstall: Downloading https://github.com/supabase/cli/releases/download/v2.24.3/supabase_linux_amd64.tar.gz239: .../node_modules/supabase postinstall: Checksum verified.240: .../node_modules/supabase postinstall: Installed Supabase CLI successfully241: .../node_modules/supabase postinstall: Done242: WARN Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/packages/cli/dist-cli/bin/cli.js'243: devDependencies:
...
254: + vercel 41.7.8255: ╭ Warning ─────────────────────────────────────────────────────────────────────╮256: │ │257: │ Ignored build scripts: @bundled-es-modules/glob, @depot/cli, │258: │ @prisma/engines, @sentry/cli, @tailwindcss/oxide, core-js-pure, esbuild, │259: │ protobufjs, sharp, style-dictionary. │260: │ Run "pnpm approve-builds" to pick which dependencies should be allowed │261: │ to run scripts. │262: │ │263: ╰──────────────────────────────────────────────────────────────────────────────╯264: frontend/apps/docs postinstall$ fumadocs-mdx265: frontend/apps/docs postinstall: [MDX] types generated266: frontend/apps/docs postinstall: Done267: frontend/internal-packages/jobs postinstall$ cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm268: frontend/internal-packages/jobs postinstall: Done269: WARN Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/@liam-hq/cli/dist-cli/bin/cli.js'270: frontend/apps/app postinstall$ cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm
...
274: with:275: path: ~/.cache/ms-playwright276: key: playwright-Linux-5a4959860dfda9c61bbb78d2e0e4a82641275ee7bbf2474053bad0f010649422277: restore-keys: playwright-Linux-278:
279: enableCrossOsArchive: false280: fail-on-cache-miss: false281: lookup-only: false282: save-always: false283: env:284: CI: true285: URL: https://liam-fg1etrupp-liambx.vercel.app286: ENVIRONMENT: Preview – liam-app287: PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin288: ##[endgroup]289: [warning]Event Validation Error: The event type deployment_status is not supported because it's not tied to a branch or tag ref.290: ##[group]Run pnpm exec playwright install --with-deps
...
1551: |■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■ | 90% of 2.3 MiB1552: |■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■| 100% of 2.3 MiB1553: FFMPEG playwright build v1011 downloaded to /home/runner/.cache/ms-playwright/ffmpeg-10111554: ##[group]Run pnpm exec playwright test --project="Mobile Safari"1555: �[36;1mpnpm exec playwright test --project="Mobile Safari"�[0m1556: shell: /usr/bin/bash -e {0}1557: env:1558: CI: true1559: URL: https://liam-fg1etrupp-liambx.vercel.app1560: ENVIRONMENT: Preview – liam-app1561: PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin1562: ##[endgroup]1563: Running 17 tests using 1 worker1564: °°°·°·××±×±···°°°°°×××××F1565: 1) [Mobile Safari] › tests/vrt/vrt.test.ts:34:5 › top ────────────────────────────────────────────1566: Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m1567: Timeout 5000ms exceeded.
...
1584: | ^1585: 22 | }1586: 23 |1587: 24 | interface TargetPage {1588: at screenshot (/home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:21:22)1589: at /home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:35:31590: attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────1591: tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png1592: ────────────────────────────────────────────────────────────────────────────────────────────────1593: attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────1594: test-results/vrt-vrt-top-Mobile-Safari/top-1-actual.png1595: ────────────────────────────────────────────────────────────────────────────────────────────────1596: attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────1597: test-results/vrt-vrt-top-Mobile-Safari/top-1-diff.png1598: ────────────────────────────────────────────────────────────────────────────────────────────────1599: Error Context: test-results/vrt-vrt-top-Mobile-Safari/error-context.md1600: Retry #1 ───────────────────────────────────────────────────────────────────────────────────────1601: �[31mTest timeout of 10000ms exceeded.�[39m1602: Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m1603: Timeout 5000ms exceeded.
...
1620: | ^1621: 22 | }1622: 23 |1623: 24 | interface TargetPage {1624: at screenshot (/home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:21:22)1625: at /home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:35:31626: attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────1627: tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png1628: ────────────────────────────────────────────────────────────────────────────────────────────────1629: attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────1630: test-results/vrt-vrt-top-Mobile-Safari-retry1/top-1-actual.png1631: ────────────────────────────────────────────────────────────────────────────────────────────────1632: attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────1633: test-results/vrt-vrt-top-Mobile-Safari-retry1/top-1-diff.png1634: ────────────────────────────────────────────────────────────────────────────────────────────────1635: Error Context: test-results/vrt-vrt-top-Mobile-Safari-retry1/error-context.md1636: attachment #5: trace (application/zip) ─────────────────────────────────────────────────────────1637: test-results/vrt-vrt-top-Mobile-Safari-retry1/trace.zip1638: Usage:1639: pnpm exec playwright show-trace test-results/vrt-vrt-top-Mobile-Safari-retry1/trace.zip1640: ────────────────────────────────────────────────────────────────────────────────────────────────1641: Retry #2 ───────────────────────────────────────────────────────────────────────────────────────1642: Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m1643: Timeout 5000ms exceeded.
...
1660: | ^1661: 22 | }1662: 23 |1663: 24 | interface TargetPage {1664: at screenshot (/home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:21:22)1665: at /home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:35:31666: attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────1667: tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png1668: ────────────────────────────────────────────────────────────────────────────────────────────────1669: attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────1670: test-results/vrt-vrt-top-Mobile-Safari-retry2/top-1-actual.png1671: ────────────────────────────────────────────────────────────────────────────────────────────────1672: attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────1673: test-results/vrt-vrt-top-Mobile-Safari-retry2/top-1-diff.png1674: ────────────────────────────────────────────────────────────────────────────────────────────────1675: Error Context: test-results/vrt-vrt-top-Mobile-Safari-retry2/error-context.md1676: Retry #3 ───────────────────────────────────────────────────────────────────────────────────────1677: Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m1678: Timeout 5000ms exceeded.
...
1695: | ^1696: 22 | }1697: 23 |1698: 24 | interface TargetPage {1699: at screenshot (/home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:21:22)1700: at /home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:35:31701: attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────1702: tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png1703: ────────────────────────────────────────────────────────────────────────────────────────────────1704: attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────1705: test-results/vrt-vrt-top-Mobile-Safari-retry3/top-1-actual.png1706: ────────────────────────────────────────────────────────────────────────────────────────────────1707: attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────1708: test-results/vrt-vrt-top-Mobile-Safari-retry3/top-1-diff.png1709: ────────────────────────────────────────────────────────────────────────────────────────────────1710: Error Context: test-results/vrt-vrt-top-Mobile-Safari-retry3/error-context.md1711: Retry #4 ───────────────────────────────────────────────────────────────────────────────────────1712: Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m1713: 2335 pixels (ratio 0.01 of all image pixels) are different.
...
1735: | ^1736: 22 | }1737: 23 |1738: 24 | interface TargetPage {1739: at screenshot (/home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:21:22)1740: at /home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:35:31741: attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────1742: tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png1743: ────────────────────────────────────────────────────────────────────────────────────────────────1744: attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────1745: test-results/vrt-vrt-top-Mobile-Safari-retry4/top-1-actual.png1746: ────────────────────────────────────────────────────────────────────────────────────────────────1747: attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────1748: test-results/vrt-vrt-top-Mobile-Safari-retry4/top-1-diff.png1749: ────────────────────────────────────────────────────────────────────────────────────────────────1750: Error Context: test-results/vrt-vrt-top-Mobile-Safari-retry4/error-context.md1751: Retry #5 ───────────────────────────────────────────────────────────────────────────────────────1752: Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m1753: 2335 pixels (ratio 0.01 of all image pixels) are different.
...
1775: | ^1776: 22 | }1777: 23 |1778: 24 | interface TargetPage {1779: at screenshot (/home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:21:22)1780: at /home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/vrt/vrt.test.ts:35:31781: attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────1782: tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png1783: ────────────────────────────────────────────────────────────────────────────────────────────────1784: attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────1785: test-results/vrt-vrt-top-Mobile-Safari-retry5/top-1-actual.png1786: ────────────────────────────────────────────────────────────────────────────────────────────────1787: attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────1788: test-results/vrt-vrt-top-Mobile-Safari-retry5/top-1-diff.png1789: ────────────────────────────────────────────────────────────────────────────────────────────────1790: Error Context: test-results/vrt-vrt-top-Mobile-Safari-retry5/error-context.md1791: 2) [Mobile Safari] › tests/e2e/page.test.ts:36:5 › Edge animation should be triggered when table node is clicked 1792: �[31mTest timeout of 10000ms exceeded.�[39m1793: Error: �[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m1794: Locator: getByRole('img', { name: 'Edge from accounts to account_aliases' }).locator('ellipse').first()1795: Expected: visible1796: Received: <element(s) not found>1797: Call log:1798: �[2m - expect.toBeVisible with timeout 5000ms�[22m1799: �[2m - waiting for getByRole('img', { name: 'Edge from accounts to account_aliases' }).locator('ellipse').first()�[22m1800: 51 |1801: 52 | const edgeEllipseAfter = edge.locator('ellipse').first()1802: > 53 | await expect(edgeEllipseAfter).toBeVisible()1803: | ^1804: 54 | })1805: 55 |1806: 56 | test('Cardinality should be highlighted when table node is clicked', async ({1807: at /home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/e2e/page.test.ts:53:341808: Error Context: test-results/e2e-page-Edge-animation-sh-894b5--when-table-node-is-clicked-Mobile-Safari/error-context.md1809: Retry #1 ───────────────────────────────────────────────────────────────────────────────────────1810: �[31mTest timeout of 10000ms exceeded.�[39m1811: Error: �[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m1812: Locator: getByRole('img', { name: 'Edge from accounts to account_aliases' }).locator('ellipse').first()1813: Expected: visible1814: Received: <element(s) not found>1815: Call log:1816: �[2m - expect.toBeVisible with timeout 5000ms�[22m1817: �[2m - waiting for getByRole('img', { name: 'Edge from accounts to account_aliases' }).locator('ellipse').first()�[22m1818: 51 |1819: 52 | const edgeEllipseAfter = edge.locator('ellipse').first()1820: > 53 | await expect(edgeEllipseAfter).toBeVisible()1821: | ^1822: 54 | })1823: 55 |1824: 56 | test('Cardinality should be highlighted when table node is clicked', async ({1825: at /home/runner/work/liam/liam/frontend/internal-packages/e2e/tests/e2e/page.test.ts:53:341826: Error Context: test-results/e2e-page-Edge-animation-sh-894b5--when-table-node-is-clicked-Mobile-Safari-retry1/error-context.md1827: attachment #2: trace (application/zip) ─────────────────────────────────────────────────────────1828: test-results/e2e-page-Edge-animation-sh-894b5--when-table-node-is-clicked-Mobile-Safari-retry1/trace.zip1829: Usage:1830: pnpm exec playwright show-trace test-results/e2e-page-Edge-animation-sh-894b5--when-table-node-is-clicked-Mobile-Safari-retry1/trace.zip1831: ────────────────────────────────────────────────────────────────────────────────────────────────1832: 3) [Mobile Safari] › tests/e2e/page.test.ts:56:5 › Cardinality should be highlighted when table node is clicked 1833: �[31mTest timeout of 10000ms exceeded.�[39m1834: 1 failed1835: [Mobile Safari] › tests/vrt/vrt.test.ts:34:5 › top ─────────────────────────────────────────────1836: 2 flaky1837: [Mobile Safari] › tests/e2e/page.test.ts:36:5 › Edge animation should be triggered when table node is clicked 1838: [Mobile Safari] › tests/e2e/page.test.ts:56:5 › Cardinality should be highlighted when table node is clicked 1839: 9 skipped1840: 5 passed (3.5m)1841: ##[error]Process completed with exit code 1.1842: ##[group]Run actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://github.com/route06/liam-internal/issues/4316
Why is this change needed?
2025/03/27に12.5.0がリリースされました。
ref. https://reactflow.dev/whats-new/2025-03-27
fitViewの実装が改善されて、意図した挙動にするためにハックしていたコードが不要になるとのことでした。
liam内では、fitViewのカスタムのために独自の useCustomReactflowを作成していたので、リリースノートの通り不要になりそうであれば、独自の実装を剥がしてしまいたいです。
What would you like reviewers to focus on?
Testing Verification
I tested it on Chrome and Safari and it worked fine on both sites.
What was done
pr_agent:summary
Detailed Changes
pr_agent:walkthrough
Additional Notes