You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR depends on #2109. Once #2109 is merged, this PR will be ready for review and the WIP prefix will be removed.
Issue
resolve: Extract duplicate path schemas in operation schema files
Why is this change needed?
Both column.ts and table.ts had duplicate path schema definitions that were used across multiple operation types. This refactoring extracts these schemas into shared constants to reduce code duplication and improve maintainability.
What would you like reviewers to focus on?
The extracted path schemas maintain the same functionality
All operation schemas correctly use the shared schemas
• Extract columnPathSchema constant from duplicate path validation • Replace inline path schemas in add/remove operations with shared schema • Maintain same validation logic and type definitions
• Extract tablePathSchema constant from duplicate path validation • Replace inline path schemas in add/remove operations with shared schema • Maintain same validation logic and type definitions
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
MH4GF
changed the title
refactor: extract shared path schemas to reduce duplication
WIP: refactor: extract shared path schemas to reduce duplication
Jun 20, 2025
The extracted columnPathSchema constant is only used twice within the same file. Consider if this level of extraction provides meaningful benefit over the original inline definitions, especially given the small scope of reuse.
constcolumnPathSchema=v.custom<`/tables/${string}/columns/${string}`>(isColumnPath,'Path must match the pattern /tables/{tableName}/columns/{columnName}',)
Similar to the column schema, the tablePathSchema constant is only used twice within the same file. The refactoring may not provide significant maintainability benefits at this limited scope.
consttablePathSchema=v.custom<`/tables/${string}`>(isTablePath,'Path must match the pattern /tables/{tableName}',)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #2109. Once #2109 is merged, this PR will be ready for review and the WIP prefix will be removed.
Issue
Why is this change needed?
Both column.ts and table.ts had duplicate path schema definitions that were used across multiple operation types. This refactoring extracts these schemas into shared constants to reduce code duplication and improve maintainability.
What would you like reviewers to focus on?
Testing Verification
What was done
🤖 Generated by PR Agent at 43fd249
• Extract duplicate path schemas into shared constants
• Reduce code duplication in column and table operation schemas
• Improve maintainability without functional changes
Detailed Changes
column.ts
Extract shared column path schema constant
frontend/packages/db-structure/src/operation/schema/column.ts
• Extract
columnPathSchema
constant from duplicate path validation•
Replace inline path schemas in add/remove operations with shared
schema
• Maintain same validation logic and type definitions
table.ts
Extract shared table path schema constant
frontend/packages/db-structure/src/operation/schema/table.ts
• Extract
tablePathSchema
constant from duplicate path validation•
Replace inline path schemas in add/remove operations with shared
schema
• Maintain same validation logic and type definitions
Additional Notes
This is a pure refactoring change with no functional modifications.
🤖 Generated with Claude Code