Minimal changes to support windows #224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalito
force-pushed
the
windows-support
branch
4 times, most recently
from
7bf5080 to
3b133fc
Compare
|
I cannot re-run the failed job here. It failed due to github-api rate limit. |
dalito
force-pushed
the
windows-support
branch
2 times, most recently
from
e8f716f to
2582ae0
Compare
|
@sujaypatil96 Your PR #225 was merged in the meantime. I rebased and resolved the conflicts here. So it is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one test failed on Windows due to a file path comparison that was not written to work cross platform.
This PR: