generated from liquibase/liquibase-extension-example
-
Notifications
You must be signed in to change notification settings - Fork 8
INT-1296 - Support to capture table description during snapshot #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/liquibase/ext/databricks/snapshot/jvm/ColumnSnapshotGeneratorDatabricks.java
Outdated
Show resolved
Hide resolved
KushnirykOleh
requested changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz add long comment (remarks) to createTable IT test and corresponding expectedSnapshot to have a test case for this bug
…and access control for Liquibase integration ♻️ (lth.yml): replace hardcoded GITHUB_TOKEN with dynamically retrieved token for better token management
…en retrieval steps and replacing them with secrets for better security and simplicity
…ing and consistency
src/test/resources/liquibase/harness/change/expectedSql/databricks/createTable.sql
Outdated
Show resolved
Hide resolved
src/test/resources/liquibase/harness/change/changelogs/databricks/createTable.xml
Show resolved
Hide resolved
KushnirykOleh
approved these changes
May 23, 2025
SvampX
approved these changes
May 23, 2025
filipelautert
approved these changes
May 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where table descriptions (comments) in Databricks were not being captured during snapshot operations, causing them to be missing in generated changelogs or not detected in diff operations.
Table SQL:
Snapshot result: