Skip to content

Redesign #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 80 commits into from
Jun 11, 2025
Merged

Redesign #20

merged 80 commits into from
Jun 11, 2025

Conversation

pblazej
Copy link
Contributor

@pblazej pblazej commented May 30, 2025

  • Rewrites most (all?) of the components to the new design for 4 major platforms/layouts:
    • iPhone
    • iPad/macOS (no Catalyst) → .regular size class
    • visionOS (slightly different layout)
  • Moves all the logic into 2 main entities:
    • AppViewModel - mostly Room state, connection, devices
    • ChatViewModel - encapsulating the chat sub-feature
      • Adds MessageSender protocol to handle local text messages
  • Adds a very simple DI and other helpers to make it happen 🎉
  • Adds a minimal CI as an echo of Create CI workflow #5

TODOs

  • CI
    • macOS now needs signing - shall we do normal fastlane match? or build for vision instead?
    • shipping BroadcastExtension maybe does more harm than good - needs app groups + team ID, without that we should be able to do Apple's SAMPLE_CODE_DISAMBIGUATOR and "automate" signing for consumers
  • README
  • Format/headers/LICENSE

Components PR: livekit/components-swift#23

@pblazej pblazej changed the title WIP: Redesign Redesign Jun 5, 2025
@pblazej pblazej marked this pull request as ready for review June 5, 2025 12:17
@pblazej pblazej requested review from hiroshihorie and ladvoc June 5, 2025 12:21
@pblazej
Copy link
Contributor Author

pblazej commented Jun 6, 2025

@hiroshihorie I saw your crash on TF, looks like nullptr

Exception Subtype: KERN_INVALID_ADDRESS at 0x0000000000000028

unfortunately, somewhere in (unsymbolicated) LiveKitWebRTC

We can try reproducing that (device change?)

Copy link
Contributor

@hiroshihorie hiroshihorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥
@pblazej it doesn't crash now, I wonder if it was some kind of perms error, did you change something related to audio ?

Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great. i don't think any of the items you mentioned are necessarily blockers to merge. i want to help improve the readmes soon

@pblazej
Copy link
Contributor Author

pblazej commented Jun 9, 2025

Nice 🔥 @pblazej it doesn't crash now, I wonder if it was some kind of perms error, did you change something related to audio ?

I just used main branch of the SDK, maybe related to the deadlock thing or other audio change...

@pblazej pblazej mentioned this pull request Jun 11, 2025
@pblazej pblazej merged commit 2cba375 into main Jun 11, 2025
2 checks passed
@pblazej pblazej deleted the blaze/redesign branch June 11, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants