Skip to content

[ASan][NFC] Remove duplicate variable AccessInfo #102305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

int-zjt
Copy link
Contributor

@int-zjt int-zjt commented Aug 7, 2024

A variable named AccessInfo was used in a condition code block, but it is declared both in and out of this condition code block.

Copy link

github-actions bot commented Aug 7, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Aug 7, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

@llvm/pr-subscribers-llvm-transforms

Author: None (int-zjt)

Changes

A variable named AccessInfo was used in a condition code block, but it is declared both in and out of this condition code block.


Full diff: https://github.com/llvm/llvm-project/pull/102305.diff

1 Files Affected:

  • (modified) llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp (-1)
diff --git a/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp b/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
index 9fb1df7ab2b79..0ff5e9b815adf 100644
--- a/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
+++ b/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
@@ -1847,7 +1847,6 @@ void AddressSanitizer::instrumentAddress(Instruction *OrigIns,
 
   InstrumentationIRBuilder IRB(InsertBefore);
   size_t AccessSizeIndex = TypeStoreSizeToSizeIndex(TypeStoreSize);
-  const ASanAccessInfo AccessInfo(IsWrite, CompileKernel, AccessSizeIndex);
 
   if (UseCalls && ClOptimizeCallbacks) {
     const ASanAccessInfo AccessInfo(IsWrite, CompileKernel, AccessSizeIndex);

@int-zjt int-zjt changed the title [AddressSanitizer] Delete duplicate variable in AddresssSanitizer Pass [ASan] Remove duplicate variable AccessInfo Aug 7, 2024
@Enna1 Enna1 requested review from vitalybuka and kstoimenov August 7, 2024 11:37
@int-zjt int-zjt changed the title [ASan] Remove duplicate variable AccessInfo [ASan][NFC] Remove duplicate variable AccessInfo Aug 7, 2024
@vitalybuka vitalybuka merged commit 2d1828d into llvm:main Aug 8, 2024
10 checks passed
Copy link

github-actions bot commented Aug 8, 2024

@int-zjt Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@llvm-ci
Copy link
Collaborator

llvm-ci commented Aug 8, 2024

LLVM Buildbot has detected a new failure on builder clang-x86_64-linux-abi-test running on sie-linux-worker2 while building llvm at step 2 "Checkout test-suite".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/8/builds/2817

Here is the relevant piece of the build log for the reference:

Step 2 (Checkout test-suite) failure: update (failure)
git version 2.34.1
fatal: unable to access 'https://github.com/llvm/llvm-test-suite.git/': Failed to connect to github.com port 443 after 135763 ms: Connection timed out
fatal: unable to access 'https://github.com/llvm/llvm-test-suite.git/': Failed to connect to github.com port 443 after 2190 ms: No route to host

@llvm-ci
Copy link
Collaborator

llvm-ci commented Aug 8, 2024

LLVM Buildbot has detected a new failure on builder lldb-aarch64-ubuntu running on linaro-lldb-aarch64-ubuntu while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/2823

Here is the relevant piece of the build log for the reference:

Step 6 (test) failure: build (failure)
...
PASS: lldb-unit :: Utility/./UtilityTests/0/8 (1991 of 2000)
PASS: lldb-unit :: ValueObject/./LLDBValueObjectTests/2/3 (1992 of 2000)
PASS: lldb-unit :: tools/lldb-server/tests/./LLDBServerTests/0/2 (1993 of 2000)
PASS: lldb-unit :: tools/lldb-server/tests/./LLDBServerTests/1/2 (1994 of 2000)
PASS: lldb-unit :: Utility/./UtilityTests/5/8 (1995 of 2000)
PASS: lldb-unit :: Utility/./UtilityTests/6/8 (1996 of 2000)
PASS: lldb-unit :: Host/./HostTests/2/11 (1997 of 2000)
PASS: lldb-unit :: Process/gdb-remote/./ProcessGdbRemoteTests/8/10 (1998 of 2000)
PASS: lldb-api :: tools/lldb-server/TestLldbGdbServer.py (1999 of 2000)
TIMEOUT: lldb-api :: functionalities/gdb_remote_client/TestGDBRemoteClient.py (2000 of 2000)
******************** TEST 'lldb-api :: functionalities/gdb_remote_client/TestGDBRemoteClient.py' FAILED ********************
Script:
--
/usr/bin/python3.8 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env ARCHIVER=/usr/local/bin/llvm-ar --env OBJCOPY=/usr/bin/llvm-objcopy --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --arch aarch64 --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/gdb_remote_client -p TestGDBRemoteClient.py
--
Exit Code: -9
Timeout: Reached timeout of 600 seconds

Command Output (stdout):
--
lldb version 20.0.0git (https://github.com/llvm/llvm-project.git revision 2d1828d29378e338cf96d78ea17d4c1833c7aac6)
  clang revision 2d1828d29378e338cf96d78ea17d4c1833c7aac6
  llvm revision 2d1828d29378e338cf96d78ea17d4c1833c7aac6

--

********************
********************
Timed Out Tests (1):
  lldb-api :: functionalities/gdb_remote_client/TestGDBRemoteClient.py


Testing Time: 667.01s

Total Discovered Tests: 3004
  Unsupported      :  490 (16.31%)
  Passed           : 2490 (82.89%)
  Expectedly Failed:   23 (0.77%)
  Timed Out        :    1 (0.03%)
FAILED: tools/lldb/test/CMakeFiles/check-lldb /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/test/CMakeFiles/check-lldb 
cd /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/test && /usr/bin/python3.8 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/llvm-lit -v /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/test
ninja: build stopped: subcommand failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants