Skip to content

[webkit.UncountedLambdaCapturesChecker] Treat a call to lambda function via a variable as safe. #135688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

[webkit.UncountedLambdaCapturesChecker] Treat a call to lambda function via a variable as safe. #135688

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41992e5
[webkit.UncountedLambdaCapturesChecker] Treat a call to lambda functi…
rniwa Apr 14, 2025
fb8444e
Add a test case for capture by value
rniwa Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ class RawPtrRefLambdaCapturesChecker
return;
DeclRefExprsToIgnore.insert(ArgRef);
LambdasToIgnore.insert(L);
Checker->visitLambdaExpr(L, shouldCheckThis() && !hasProtectedThis(L),
ClsType, /* ignoreParamVarDecl */ true);
}

bool hasProtectedThis(LambdaExpr *L) {
Expand Down
8 changes: 8 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,14 @@ void trivial_lambda() {
trivial_lambda();
}

bool call_lambda_var_decl() {
RefCountable* ref_countable = make_obj();
auto lambda = [&]() -> bool {
return ref_countable->next();
};
return lambda();
}

void lambda_with_args(RefCountable* obj) {
auto trivial_lambda = [&](int v) {
obj->method();
Expand Down
Loading