fpcmp: Allow decimal numbers ending with a period #251
Conversation
|
Thanks for working on this. Could you add one or more tests in tools/test? There are some there that you may be model off of, if needed. That may help prevent regressions like this. |
After 8a84a50, fpcmp requires at least one post-decimal digit when period present. This leads to incorrect comparison results for 628.pop2_s of SPEC2017 because this program outputs `65.` when the Fortran compiler is flang while the reference output is `65.0`.
Thanks. Added. |
tools/test/CMakeLists.txt
Outdated
| @@ -19,6 +23,10 @@ add_dependencies(abrt not) | |||
| llvm_test_run(EXECUTABLE "$<TARGET_FILE:not>" "--crash" "$<TARGET_FILE:abrt>") | |||
| llvm_add_test_for_target(abrt) | |||
|
|
|||
| # Check that fpcmp can handle decimal numbers ending with a period correctly. | |||
| llvm_test_run(EXECUTABLE "$<TARGET_FILE:fpcmp-target>" "-a" "0.03" "-r" "0.03" "-i" "%b/test/fpcmp-input1" "%b/test/fpcmp-input2") | |||
There was a problem hiding this comment.
The tolerance of 0.03 here seems fairly large. Do you expect that it will fail if it is made smaller?
There was a problem hiding this comment.
628_pop2 uses 0.03 for both absolute and relative tolerance.
# SPEC Test has both absolute and relative tolerance with same order
speccpu2017_verify_output(IGNORE_WHITESPACE ABSOLUTE_TOLERANCE 0.03 RELATIVE_TOLERANCE 0.03)
How about using a bigger value in the test file? For example: change 3.0E-02 to 1003.0E-02.
There was a problem hiding this comment.
628_pop2 uses 0.03 for both absolute and relative tolerance.
# SPEC Test has both absolute and relative tolerance with same order speccpu2017_verify_output(IGNORE_WHITESPACE ABSOLUTE_TOLERANCE 0.03 RELATIVE_TOLERANCE 0.03)How about using a bigger value in the test file? For example: change
3.0E-02to1003.0E-02.
Thanks for the clarification. Since this was motivated by 628_pop2 anyway, the tolerance is probably appropriate. There's no need for larger values.
After 8a84a50, fpcmp requires at least one post-decimal digit when period present. This leads to incorrect comparison results for 628.pop2_s of SPEC2017 because this program outputs
65.if the Fortran compiler is flang while the reference output is65.0.