love-android as a library #290
Conversation
convert love android into a library, add sample app that integrates it
| @@ -18,50 +21,121 @@ jobs: | |||
| - name: Checkout | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| submodules: true | |||
| submodules: false # We'll handle this manually for better control | |||
There was a problem hiding this comment.
Any reason why we don't need to clone submodules? For someone who wants to compile from source quickly, they can just do:
$ git clone --recurse-submodules https://github.com/love2d/love-android
$ cd love-android
$ gradlew assemble
Instead of having to manually re-clone the needed repository (megasource and main LOVE)
| @@ -18,50 +21,121 @@ jobs: | |||
| - name: Checkout | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| submodules: true | |||
| submodules: false # We'll handle this manually for better control | |||
| token: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
token is ${{ github.token }} (alias of secrets.GITHUB_TOKEN) by default. This is redundant.
| - name: Initialize Submodules (Robust) | ||
| run: | | ||
| echo "=== Initial Git Status ===" | ||
| git status | ||
| echo "=== Checking .gitmodules ===" | ||
| cat .gitmodules || echo "No .gitmodules found" | ||
| echo "=== Checking git config for submodules ===" | ||
| git config --list | grep submodule || echo "No submodule config found" | ||
| echo "=== Checking .git/modules ===" | ||
| ls -la .git/modules/ || echo "No .git/modules found" | ||
| echo "=== Force clean submodule state and re-init ===" | ||
| git submodule deinit --all --force || true | ||
| rm -rf .git/modules/library || true | ||
| rm -rf .git/modules/app || true | ||
| echo "=== Re-sync and init submodules ===" | ||
| git submodule sync --recursive | ||
| git submodule update --init --recursive --force | ||
| echo "=== Submodule status after clean init ===" | ||
| git submodule status --recursive | ||
| echo "=== Manual clone fallback if needed ===" | ||
| if [ ! -d "library/src/main/cpp/love" ]; then | ||
| echo "Love submodule still missing, manual clone..." | ||
| mkdir -p library/src/main/cpp | ||
| git clone https://github.com/love2d/love.git library/src/main/cpp/love --depth 1 | ||
| fi | ||
| if [ ! -d "library/src/main/cpp/megasource" ]; then | ||
| echo "Megasource submodule still missing, manual clone..." | ||
| mkdir -p library/src/main/cpp | ||
| git clone https://github.com/love2d/megasource.git library/src/main/cpp/megasource --depth 1 | ||
| fi | ||
| echo "=== Final verification ===" | ||
| ls -la library/src/main/cpp/ | ||
| ls -la library/src/main/cpp/love/ | head -5 || echo "love directory empty/missing" | ||
| ls -la library/src/main/cpp/megasource/ | head -5 || echo "megasource directory empty/missing" |
There was a problem hiding this comment.
Any particular reason why we have to clone the submodules manually? This breaks people who just want to compile quickly (see my above review).
| distribution: 'temurin' # adopt-hotspot is an alias for temurin | ||
| java-version: '17' # This will pick the latest 17.x | ||
| # Or be more specific like '17.0.10' if '17.0.15' is problematic |
There was a problem hiding this comment.
Single quotes is redundant.
As for the comment, the exact version specifier comment is also bit out of place. Always stick to just the major version. If specific version has issue then it's upstream issue and should be reported.
| distribution: 'temurin' # adopt-hotspot is an alias for temurin | |
| java-version: '17' # This will pick the latest 17.x | |
| # Or be more specific like '17.0.10' if '17.0.15' is problematic | |
| distribution: temurin | |
| java-version: 17 |
| About fork: | ||
| --------- | ||
| This is a fork of the original project, it moves the app into a library and publishes it into an aar for easy app integration. | ||
|
|
||
| https://jitpack.io/#eltonkola/love-android/Tag | ||
|
|
||
| if there is interest we can clean it and try to merge into the main project | ||
|
|
There was a problem hiding this comment.
Please remove this line. Thanks.
There was a problem hiding this comment.
We're using Java, not Kotlin. Either convert this to Java or don't add test.
There was a problem hiding this comment.
We're using Java, not Kotlin. Please convert this to Java.
There was a problem hiding this comment.
We're using Java, not Kotlin. Please convert this to Java. (There may be more Kotlin files, please do the same. This will be my last comment on this)
There was a problem hiding this comment.
Any particular reason this exist?
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
|
|
||
| <style name="Theme.LÖVEForAndroid" parent="android:Theme.Material.Light.NoActionBar" /> |
There was a problem hiding this comment.
Keep style name plain ASCII.
| <style name="Theme.LÖVEForAndroid" parent="android:Theme.Material.Light.NoActionBar" /> | |
| <style name="Theme.LOVEAndroid" parent="android:Theme.Material.Light.NoActionBar" /> |
This is a suggestion about converting the app into a library, so we can publish an aar that can easily be integrated on a new app.
This is just a suggestion for now.
This pr does most of the job, but may be a few things what should be fixed.
My goal was to make it work with jitpack, but unfortunately was not able to make it work, if authors decide to consider this change, publishing in maven centra would be the real goal.
For now i modified the github action to upload the binaries, and successfully used it on my app via aar dependency :
flatDir {
dirs("app/libs")
}
implementation(mapOf("name" to "library-embed-record-release", "ext" to "aar"))