-
Notifications
You must be signed in to change notification settings - Fork 313
Development
: Defer eager bean initialization and refactor services to reduce server startup time
#10951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore/mark-everything-as-lazy
Are you sure you want to change the base?
Development
: Defer eager bean initialization and refactor services to reduce server startup time
#10951
Conversation
This reverts commit 1444dec.
…peedup initial start
Development
: Speedup server startDevelopment
: Deferred eager bean initialization and service refactorings to reduce number of bean instantiations at startup
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary
|
src/main/java/de/tum/cit/aet/artemis/buildagent/service/SharedQueueProcessingService.java
Outdated
Show resolved
Hide resolved
End-to-End (E2E) Test Results Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. So far no errors found
Development
: Deferred eager bean initialization and service refactorings to reduce number of bean instantiations at startupDevelopment
: Defer eager bean initialization and refactor services to reduce server startup time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deployed and tested this in TS2 with multiple accounts, student, instructor and admin, and different exercises, and didn't observe anything broken.
But I had a weird helios issue, where despite building the image and deploying it, helios doesn't reflect it. it's stuck in this state (for the past 15 minutes).

I don't know whether this is due to helios, a fault of my own or something in your code that breaks it. I inspected the build logs on GitHub and to see it was deployed. I assume its probably just a visual bug, since as I wrote this review it updated.
Checklist
General
Server
Motivation and Context
Server startup is quite slow. Locally it takes ~40s. On production it takes multiple minutes.
Stacked on top of #10962 for easier reviewing.
Description
Steps for Testing
For manual testing you can approve both and this PR
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Test Coverage
unchanged