February 13th, 2019

[lenaorobei]

Please add your topic as a comment to the issue. Use following format:
Topic description and link to PR, if any (duration in min)

Meeting Notes

• Vote on version specific rules
• Research on count in loop
• Need feedback on setTemplate
• Review and comment on commits verification tool

Recording: no recording due to tech difficulties

[lenaorobei]

Magento Coding Standard (20 min)

• Version Specific Rules
• Remove unstable Annotation sniffs and replace with OOB ones
  New rules:
• Slow array SHOULD NOT be used in loop
• The use of literal logical operators MUST be avoided
• Multiple isset statements SHOULD be combined into one
• Function/method call in for loop declaration MUST be avoided
• Do not use setTemplate in Block classes
• Add declare(strict_types=1) to your PHP files
• Controllers Should Implement HTTP Method Marker Interface @sprankhub
• Using phpro/grumphp for local quality check @larsroettig

[diazwatson]

I won't be able to attend this time (I will watch the recording later on) but I was wondering...
What about adding rules and sniffs for CSS and JS?

I know that PHP_CodeSniffer tool can be also used for this but I have not seen anything related in the Magento Extension Quality Program Coding Standard

It would be nice if somebody can answer this.
Thanks in advance

[orlangur]

@diazwatson there are a lot of such sniffs in main repo: https://github.com/magento/magento2/tree/2.3-develop/dev/tests/static/framework/Magento/Sniffs/Less

For JS another tooling from JS-ecosystem is used currently but I do agree that it would be nice to make JS code as much consistent with PHP as possible.

[orlangur]

@diazwatson,

I know that PHP_CodeSniffer tool can be also used for this but I have not seen anything related in the Magento Extension Quality Program Coding Standard

https://github.com/magento/magento-coding-standard repo for now is more like a new incarnation of MEQP repo rather than a real Magento standard existed for years.

[diazwatson]

It would be nice to re organise all those repos (and maybe the sniffs in https://github.com/magento/magento2/tree/2.3-develop/dev/tests/static/framework/Magento/Sniffs/*) in just one place.

That would be a great topic of discussion for sure

[lenaorobei]

@diazwatson

It would be nice to re organise all those repos (and maybe the sniffs in https://github.com/magento/magento2/tree/2.3-develop/dev/tests/static/framework/Magento/Sniffs/*) in just one place.

That's exactly what magento/magento-coding-standard stands for. Here is the related task - magento/magento-coding-standard#4

[orlangur]

@diazwatson,

It would be nice to re organise all those repos (and maybe the sniffs in https://github.com/magento/magento2/tree/2.3-develop/dev/tests/static/framework/Magento/Sniffs/*) in just one place.

Yep, moving existing and working stuff from static tests somewhere to https://github.com/magento/magento2/tree/2.3-develop/lib/internal/Magento/Framework instead of making one more repo (reminds me https://xkcd.com/927/) and then improving it iteration-by-iteration with MEQP and other useful sniffs would be really great. Approach described in issue mentioned by Lena is kinda opposite.

[diazwatson]

Great news @orlangur @lenaorobei !!!
Will the rules and sniffs from MEQP1 be also included in this new all in one standard repo?

[lenaorobei]

@diazwatson Magento Coding Standard will include rules for Magento 2.x only.
MEQP1 will remain the part of Marketplace until Magento 1.x we stop accepting Magento 1.x extensions.