-
Notifications
You must be signed in to change notification settings - Fork 9.4k
improved error reporting when unexpected went wrong #36969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
improved error reporting when unexpected went wrong #36969
Conversation
Hi @mrtuvn. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@@ -29,6 +29,7 @@ define([ | |||
try { | |||
error = JSON.parse(response.responseText); | |||
} catch (exception) { | |||
console.error(exception); | |||
error = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the question here we actual want to expose errors to console may cause vulnerable web application ?
Description (*)
show an error/exception in the browser's console allow developer can figure what exactly problem when something went wrong.
Message "Something went wrong with your request. Please try again later." not useful for debugging. We dont need that context for check problem as developer.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)