Skip to content

Tailwindui css layout support - Add more htmlClasses #37563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

in-session
Copy link
Contributor

@in-session in-session commented Jun 1, 2023

Supports classes with !important as used in Tailwind 3
https://tailwindcss.com/docs/configuration#important-modifier

<p class="font-bold md:!font-medium">

Follow-up on #36452

Related Pull Requests

magento/magento2-page-builder#791

Resolved issues:

  1. resolves [Issue] Tailwindui css layout support - Add more htmlClasses #37568: Tailwindui css layout support - Add more htmlClasses

Supports classes with !important as used in Tailwind 3
https://tailwindcss.com/docs/configuration#important-modifier

<p class="font-bold md:!font-medium">
@m2-assistant
Copy link

m2-assistant bot commented Jun 1, 2023

Hi @in-session. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ihor-sviziev ihor-sviziev added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 1, 2023
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@ihor-sviziev
Copy link
Contributor

@in-session, in order to brocess both PRs at once #37563 and magento/magento2-page-builder#791 - I linked them to together.
Hope this will speed up processing of both

@ihor-sviziev ihor-sviziev changed the title Allow more htmlClasses Tailwindui css layout support - Allow more htmlClasses Jun 1, 2023
@ihor-sviziev ihor-sviziev changed the title Tailwindui css layout support - Allow more htmlClasses Tailwindui css layout support - Support more htmlClasses Jun 1, 2023
@ihor-sviziev ihor-sviziev changed the title Tailwindui css layout support - Support more htmlClasses Tailwindui css layout support - Add more htmlClasses Jun 1, 2023
@ihor-sviziev
Copy link
Contributor

@sidolov, for some reason, the pull request from page builder repository wasn't linked properly - it's not used in tests. Could you pls help with it?

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento create issue

@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

  • In app code - /magento2/app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml add font-bold md:!font-medium in the htmlClass.
    For Ex- htmlClass="product-info-main font-bold md:!font-medium"
  • Run bin/magento indexer:reindex && bin/magento c:f
  • Go to frontend open PDP.

Before: ✖️ Throwing error on PDP.

Frontend:
Screenshot 2023-06-02 at 5 29 59 PM

Logs:
Screenshot 2023-06-02 at 5 34 39 PM

After: ✔️ Now working fine.

Screenshot 2023-06-05 at 12 11 54 PM

Moving to Merge in progress

@ihor-sviziev
Copy link
Contributor

@engcom-Lima, did you check the page builder changes as well?

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 3b5d215 into magento:2.4-develop Aug 31, 2023
@in-session in-session deleted the patch-22 branch September 1, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept
Projects
Status: Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] Tailwindui css layout support - Add more htmlClasses
4 participants