Skip to content

Improve backoffice category display performance #39830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

Dnd-Mafer
Copy link
Contributor

@Dnd-Mafer Dnd-Mafer commented Apr 17, 2025

This PR improvement performance of categroy display in BO. It fixes #39829

Description

This PR change a time consuming subselect in SQL query for a fast join.

Fixed Issues

Fixes #39829

Manual testing scenarios

Connect to BO
Go on Catalog -> Category
Check that numbers in parenthesis near category names are corresponding to number of category products

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Apr 17, 2025

Hi @Dnd-Mafer. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@Dnd-Mafer
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented May 16, 2025

Hello @Dnd-Mafer,

Please merge the latest changes from https://github.com/magento/magento2 to this branch. We are unable to do so due to access issue. Meanwhile moving this PR On Hold.

Thanks

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the performance of the backoffice category display by replacing a time-consuming subselect with a faster join approach.

  • Removed the IN subselect in the SQL query
  • Introduced a joinLeft on the category entity table to handle category hierarchy
  • Updated the join condition for product counts
Comments suppressed due to low confidence (2)

app/code/Magento/Catalog/Model/ResourceModel/Category/Collection.php:386

  • The updated join condition using a direct expression may not exactly replicate the previous subselect behavior, potentially affecting product counts for categories with multiple hierarchy levels. Please verify that this join logic covers the full intended category hierarchy.
new \Zend_Db_Expr("ce2.path LIKE CONCAT(ce.path, '/%') OR ce2.path = ce.path")

app/code/Magento/Catalog/Model/ResourceModel/Category/Collection.php:392

  • Changing the join condition to an equality match may not account for all children categories as the previous subselect did. Confirm that this logic accurately maintains the intended relationship between categories and their products.
cp.category_id = ce2.entity_id

@engcom-Hotel
Copy link
Contributor

Hello @Dnd-Mafer,

Gentle reminder to update the branch with the latest updates 2.4-develop. Or give us access to do the same. Till the time moving this PR On Hold.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to On Hold in Community Dashboard May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: on hold Project: Community Picked PRs upvoted by the community
Projects
Status: On Hold
Development

Successfully merging this pull request may close these issues.

Backoffice category tree takes an incredibly long time to display in 2.4.8
3 participants