Skip to content

Added a pure numba hillshade that is 10x faster compared to numpy #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

alex-soklev
Copy link
Contributor

The new code uses less context switching and data transfers, minimizes communication overhead and removes the cupy dependency. I've made it run by default, if cuda is available. Otherwise if falls back to numpy

This change addresses issue #541

@brendancol
Copy link
Contributor

  • change to I/O to cupy arrays

@brendancol
Copy link
Contributor

@thuydotm can you review this and get back with any comments?

@thuydotm
Copy link
Contributor

Thanks @a7az0th!
I think we can now remove the old run_cupy function and replace it with the run_numba since the old code is no longer called. run_numba should be renamed to run_cupy to be consistent with our coding convention. Otherwise looks good to me.

@alex-soklev
Copy link
Contributor Author

@thuydotm I've updated the source according to your feedback. I believe we can merge this.

@thuydotm thuydotm merged commit afca7d7 into makepath:master Sep 16, 2021
@thuydotm
Copy link
Contributor

Merged, thanks!

@alex-soklev
Copy link
Contributor Author

Thank you, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants