Pr/552 fix #557
Merged
Pr/552 fix #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuydotm
added a commit
that referenced
this pull request
Sep 28, 2021
* adds fast_perline and fast_terrain modules * fixes import * Adds two new notebook examples * updates readme, cupy and dask supported for perlin and terrain generation * refactor * add tests * update test * update tests * added perlin tests * terrain: dask case * Pr/552 fix (#557) * Fixes bug in perlin gpu * uses cuda_args to configure block and grid size * Using numpy for permutation makes the Cuy implementation 4-5x slower * typo fix * ensure numpy, dask, and cupy perlin return the same output * ensure numpy, dask, and cupy generate_terrain return the same output * flake8 fixes * generate_terrain: correct resolution of output data array * temporarily exclude benchmark notebooks Co-authored-by: Konstantinos Iliakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an odd artifact in perlin noise output
Proposed Changes
xrspatial.utils.cuda_argsto configure block and grid sizespermutationmethod instead ofarange+shuffle