Skip to content

httpCookies option #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

httpCookies option #259

wants to merge 2 commits into from

Conversation

marcbachmann
Copy link
Owner

No description provided.

@marcbachmann marcbachmann mentioned this pull request Mar 21, 2017
Closed
chriskinsman
chriskinsman requested changes Mar 22, 2017
View reviewed changes
Copy link
Collaborator

@chriskinsman chriskinsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have a test for this?

@marcbachmann
Copy link
Owner Author

Now there is. Yesterday I tried to write one in js. But phantomjs doesn't allow access to document.cookie

@marcbachmann
Copy link
Owner Author

I hate that we only have pseudo tests.
We would have to read the pdf again and check what's rendered.

@chriskinsman
Copy link
Collaborator

Yep have run into that myself writing the renderDelay tests...

@marcbachmann marcbachmann mentioned this pull request Sep 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskinsman chriskinsman chriskinsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcbachmann @chriskinsman @seyfert