Add ability to trigger render from page code #264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alling the phantomjs page.render
…back() Interlock the onLoadFinished and onCallback
|
@chriskinsman Do you know whether this functionality is going to be merged? |
|
Would love it to be but it needs an approved review it says. Looks like there have not been any merges since February so not sure if the current maintainer is working on it any longer... |
|
Released in v2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was surprisingly difficult to get everything working.
onCallback and onLoadFinished need to be interlocked so that page.render() is not called before the onLoadFinished callback fires. If this happens nothing will be rendered.
If onCallback arrives before onLoadFinished a flag is set to indicate that when onLoadFinished is called it should immediately render instead of waiting the renderDelay.
If onLoadFinished arrives before onCallback a flag is set to indicate that onLoadFinished has completed and the renderDelay is started. When onCallback arrives and sees that onLoadFinished has already arrived it cancels the renderDelay and renders the page.
Test is included that checks to see if the page is rendered in < 10s vs the renderDelay timeout of 120s.
Any further testing would require reading of the PDF...