Skip to content

MCOL-4202: crossdb rename [stable23.10] #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

MCOL-4202: crossdb rename [stable23.10] #3067

merged 1 commit into from
Dec 18, 2023

Conversation

mariadb-LeonidFedorov
Copy link
Collaborator 

uint8_t updateSyscolumnTablename(messageqcpp::ByteStream& bs, std::string& err);
uint8_t updateSystableTablename(messageqcpp::ByteStream& bs, std::string& err);

this functions were written in assumption we are renaming table only on the same schema
the code is ugly mix of low level manipulations and logic, so I refactored a helper function for both and call it twice

drrtuy
drrtuy approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@drrtuy drrtuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ACK

@mariadb-LeonidFedorov mariadb-LeonidFedorov merged commit 97abd98 into stable-23.10 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drrtuy drrtuy drrtuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariadb-LeonidFedorov @drrtuy