-
Notifications
You must be signed in to change notification settings - Fork 546
fix(MCPServer): Session tool handler not used due to variable shadowing #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧬 Code Graph Analysis (1)server/server.go (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Problem
This PR fixes a bug where session-specific tool handlers were never used, and MCPServer always fell back to global tool handlers.
The issue was caused by variable shadowing in the following block of code:
The
ok
declared inif sessionWithTools, ok := ....
shadows the outerok
variable declared in the function:As a result, setting
ok = true
inside thisif
block had no effect on the outer variable, and the following loginc:was always executed, even if a session tool was actually found.
Fix
This fix simply avoids shadowing by renaming the inner variable:
This ensures that the outer
ok
variable reflects whether a session-specific tool was found and used.Summary by CodeRabbit
Tests
Refactor