Skip to content

fix: logo on website is squashed #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

Conversation

corani
Copy link
Contributor

@corani corani commented May 29, 2025

Description

When I fiddle with the CSS in the browser, this seems to fix the issue. According to https://vocs.dev/docs/guides/theming#class-theming, Vocs should automatically pick up the styles.css file, so I hope this works 😃

Fixes #343

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • MCP spec compatibility implementation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Tests only (no functional changes)
  • Other (please describe):

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the documentation accordingly

MCP Spec Compliance

  • This PR implements a feature defined in the MCP specification
  • Link to relevant spec section: Link text
  • Implementation follows the specification exactly

Additional Information

Summary by CodeRabbit

  • Style
    • Updated the homepage logo to automatically adjust its size while maintaining its aspect ratio for improved visual appearance.

When I fiddle with the CSS in the browser, this seems to fix the issue. According to https://vocs.dev/docs/guides/theming#class-theming, Vocs should automatically pick up the `styles.css` file, so I hope this works 😃 

Closes mark3labs#343
Copy link
Contributor

coderabbitai bot commented May 29, 2025

Walkthrough

A CSS rule targeting the .vocs_HomePage_logo class was added to the stylesheet, setting its height to auto, max-width to 100%, and object-fit to contain. No other files or exported entities were modified.

Changes

Files/Groups Change Summary
www/styles.css Added .vocs_HomePage_logo CSS rule with height: auto; max-width: 100%; object-fit: contain;

Assessment against linked issues

Objective Addressed Explanation
Fix abnormal display of the official website logo (#343)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a6fd29 and 82bb071.

📒 Files selected for processing (1)
  • www/styles.css (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • www/styles.css

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
www/styles.css (1)

1-3: Ensure cross-browser compatibility and maintain aspect ratio
The new rule correctly targets the logo to fix the squashing, but height: fit-content isn’t universally supported. To preserve the logo’s intrinsic proportions and provide a more reliable fallback, consider:

.vocs_HomePage_logo {
  height: auto;
  width: auto;
  object-fit: contain;
}

This approach maintains aspect ratio across browsers and adapts smoothly to varying container constraints.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfc3773 and 731b0f3.

📒 Files selected for processing (1)
  • www/styles.css (1 hunks)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
www/styles.css (2)

2-4: Consider using max-width for responsiveness
A more common responsive pattern is to use max-width: 100% with height: auto; this ensures the logo can shrink on smaller viewports without overflowing its container.
Diff suggestion:

 .vocs_HomePage_logo {
-  width: auto;
+  max-width: 100%;
   height: auto;
   object-fit: contain;
 }

4-4: Provide fallback for object-fit
object-fit isn’t supported in some legacy browsers (e.g., Internet Explorer). If you need broader compatibility, consider a CSS background-image approach or wrapping the <img> in a container with background-size: contain.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 731b0f3 and 8a6fd29.

📒 Files selected for processing (1)
  • www/styles.css (1 hunks)
🔇 Additional comments (1)
www/styles.css (1)

1-5: Preserves logo aspect ratio
The added rule .vocs_HomePage_logo sets both dimensions to auto and uses object-fit: contain, which should maintain the original logo proportions and resolve the squashed appearance.

@corani
Copy link
Contributor Author

corani commented May 29, 2025

According to https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit#browser_compatibility, object-fit is widely supported by all modern browsers.

(Suggest to squash the commits when merging, I made a few edits based on coderabbit suggestions).

@rwjblue-glean rwjblue-glean merged commit 991b31c into mark3labs:main May 29, 2025
1 check passed
@rwjblue-glean
Copy link
Collaborator

Thank you!!

@corani corani deleted the patch-1 branch May 30, 2025 03:16
@coderabbitai coderabbitai bot mentioned this pull request Jun 4, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: the logo of the official website is displayed abnormally
2 participants