-
Notifications
You must be signed in to change notification settings - Fork 474
fix: logo on website is squashed #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When I fiddle with the CSS in the browser, this seems to fix the issue. According to https://vocs.dev/docs/guides/theming#class-theming, Vocs should automatically pick up the `styles.css` file, so I hope this works 😃 Closes mark3labs#343
WalkthroughA CSS rule targeting the Changes
Assessment against linked issues
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
www/styles.css (1)
1-3
: Ensure cross-browser compatibility and maintain aspect ratio
The new rule correctly targets the logo to fix the squashing, butheight: fit-content
isn’t universally supported. To preserve the logo’s intrinsic proportions and provide a more reliable fallback, consider:.vocs_HomePage_logo { height: auto; width: auto; object-fit: contain; }This approach maintains aspect ratio across browsers and adapts smoothly to varying container constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
www/styles.css (2)
2-4
: Consider using max-width for responsiveness
A more common responsive pattern is to usemax-width: 100%
withheight: auto
; this ensures the logo can shrink on smaller viewports without overflowing its container.
Diff suggestion:.vocs_HomePage_logo { - width: auto; + max-width: 100%; height: auto; object-fit: contain; }
4-4
: Provide fallback for object-fit
object-fit
isn’t supported in some legacy browsers (e.g., Internet Explorer). If you need broader compatibility, consider a CSS background-image approach or wrapping the<img>
in a container withbackground-size: contain
.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
www/styles.css
(1 hunks)
🔇 Additional comments (1)
www/styles.css (1)
1-5
: Preserves logo aspect ratio
The added rule.vocs_HomePage_logo
sets both dimensions to auto and usesobject-fit: contain
, which should maintain the original logo proportions and resolve the squashed appearance.
According to https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit#browser_compatibility, (Suggest to squash the commits when merging, I made a few edits based on coderabbit suggestions). |
Thank you!! |
Description
When I fiddle with the CSS in the browser, this seems to fix the issue. According to https://vocs.dev/docs/guides/theming#class-theming, Vocs should automatically pick up the
styles.css
file, so I hope this works 😃Fixes #343
Type of Change
Checklist
MCP Spec Compliance
Additional Information
Summary by CodeRabbit