Skip to content
This repository was archived by the owner on Jan 19, 2024. It is now read-only.

WIP Azure Pipelines trigger (forked) #141

Closed
wants to merge 4 commits into from

Conversation

davidzwa
Copy link
Contributor

Fork and own work on other PR by sloria

@davidzwa davidzwa changed the title WIP Azure Pipelines trigger (forked0 WIP Azure Pipelines trigger (forked) Apr 12, 2020
@davidzwa
Copy link
Contributor Author

davidzwa commented Apr 12, 2020

So I find the templates given in which refer to job--python-tox quite complex and I notice there is no step to just simply 'install dependencies', which the base pytest-azure-pipelines does automatically.

I see no issue in just using the azure pytest basic template? We can use pytest-lint and something else for the docs. We'd need to find a way to export the coverage and test output artifact, if you are in need of that info.

You should hook up Pypi service when you feel ready for it as it requires editing the Azure project.

@davidzwa
Copy link
Contributor Author

@sloria it'd be great to hear your thoughts!

@sloria
Copy link
Member

sloria commented Apr 15, 2020

Sorry haven't had a chance to look yet... it'd be great if this could be put in line with the other marshmallow-code repos, i.e. use the same templates.

The idea with the tox jobs is that they use tox to create an virtualenv and install dependencies, rather than installing in the "global" virtual environment. This is very convenient for reproducing issues locally.

@davidzwa
Copy link
Contributor Author

davidzwa commented Apr 16, 2020

The tox template fails (I tried) because it misses installing the dependencies of requirements.txt. So I'd need to extend the template, or you'd need to add it to your repo.

I will do the extension, although I am new to it. Nice to learn.

@sloria
Copy link
Member

sloria commented Apr 16, 2020

Rather than modify the AP templates, I think the better approach is to bring this project in line with the rest of marshmallow-code, i.e. use setup.py instead of requirements.txt.

Example: https://github.com/marshmallow-code/flask-marshmallow/blob/dev/setup.py#L6-L22

This allows each tox environment to only install the minimum necessary requirements. Note: you'll also need to update tox.ini.

@davidzwa
Copy link
Contributor Author

I've recovered my energy to work and will look at this tomorrow evening.

@davidzwa davidzwa closed this Oct 11, 2023
@davidzwa davidzwa deleted the azure-pipelines branch October 11, 2023 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants