Add read receipt times to the hovertip of read markers #586
Conversation
Fixes #2709. Surprisingly, this data was never passed down to ReadReceiptMarker.
|
I don't understand why Travis is upset with me. |
| var room = this.props.matrixClient.getRoom(this.props.mxEvent.getRoomId()); | ||
| if (room) { | ||
| // [ {type/userId/data} ] | ||
| room.getReceiptsForEvent(this.props.mxEvent).forEach(function(r) { |
There was a problem hiding this comment.
I'm not terribly happy about this being here as well as this.props.readReceipts. It gives a very odd interface to this component, which is becoming less and less 'view'-like.
Can we push this up into MessagePanel and add the timestamp data to this.props.readReceipts?
There was a problem hiding this comment.
I'm confused. I have not changed the interface to this component.
I dislike how this.props.readReceipts aren't read receipts at all, and are in fact a list of RoomMembers, which is why I have to contort like this. Are you asking for me to modify the interface to this component to make this.props.readReceipts actually be read receipts with an additional roomMember field?
|
(I don't know what's up with travis either; will investigate) |
Instead of passing a list of RoomMembers, pass a list of records with a `roomMember` prop and a `ts` prop so we can display the timestamp on hover.
|
@richvdh PTAL |
Fixes element-hq/element-web#2709. Surprisingly, this data was never passed down to
ReadReceiptMarker.