This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Use an eslint config based on the js-sdk #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the js sdk's eslint config to give as consistent a code style as possible. Add react/jsx/flow stuff that we use here.
eslint --fix and a few manual ones
|
Haven't been through all your rule choices, but looks great. We should also do the --max-warnings thing here to keep ourselves honest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try & get as consistent a code-style as possible throughout our various codebases. This config adds jsx/react/flow stuff, and makes some things warnings again that the react-sdk doesn't conform to yet.
Run eslint --fix to fix a bunch of errors (a lot of missing semicolons), but there are still a bunch of errors that probably warrant looking into, but too many that I want to start doing so now. The fact that it throws up these errors probably makes doing this worthwhile. IMO.