Skip to content

refactor: Use native async fn in traits for widget::CapabilitiesProvider #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented May 29, 2025

The main thing left now are the store traits, unsure how to deal with those. dynosaur + trait_variant are kind of the modern replacement for async_trait, but (a) trait_variant seemed to generate invalid code here when I tried it and (b) even with that fixed I think the error type erasure is going to present some extra problems. Maybe it's fine to just keep the current solution for the store traits for now.

Signed-off-by: Jonas Platte [email protected]

@jplatte jplatte force-pushed the jplatte/async-trait-again branch from f0ceff2 to 1709aba Compare June 19, 2025 11:17
@jplatte jplatte changed the title refactor: Use native async fn in traits more refactor: Use native async fn in traits for widget::CapabilitiesProvider Jun 19, 2025
@jplatte jplatte force-pushed the jplatte/async-trait-again branch from 1709aba to ad0787e Compare June 19, 2025 11:25
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (b4146ca) to head (ad0787e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5135      +/-   ##
==========================================
- Coverage   90.15%   90.13%   -0.03%     
==========================================
  Files         334      334              
  Lines      104717   104717              
  Branches   104717   104717              
==========================================
- Hits        94408    94385      -23     
- Misses       6255     6278      +23     
  Partials     4054     4054              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jplatte jplatte marked this pull request as ready for review June 19, 2025 11:36
@jplatte jplatte requested a review from a team as a code owner June 19, 2025 11:36
@jplatte jplatte requested review from andybalaam and removed request for a team June 19, 2025 11:36
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay let's kill all uses of async-trait with 🔥 🔥 🔥 (as it has pathologically slowed down compilation in the past)

@bnjbvr bnjbvr removed the request for review from andybalaam June 19, 2025 11:38
@jplatte jplatte enabled auto-merge (squash) June 19, 2025 11:40
@jplatte jplatte disabled auto-merge June 19, 2025 11:41
@jplatte jplatte enabled auto-merge (squash) June 19, 2025 11:41
@jplatte jplatte merged commit e7e9d5b into main Jun 19, 2025
51 checks passed
@jplatte jplatte deleted the jplatte/async-trait-again branch June 19, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants