Skip to content

Indexeddb: support for received room key bundles #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 24, 2025

Add a new store to keep track of the information we have received about room key bundles for MSC4268.

Fixes: #5107

@richvdh richvdh force-pushed the rav/history_sharing/indexeddb_support branch 2 times, most recently from 1c47b74 to b4f4ec8 Compare June 24, 2025 11:57
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (1f98e0c) to head (83ad34d).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5276      +/-   ##
==========================================
- Coverage   90.18%   90.18%   -0.01%     
==========================================
  Files         334      334              
  Lines      104824   104824              
  Branches   104824   104824              
==========================================
- Hits        94540    94539       -1     
- Misses       6232     6233       +1     
  Partials     4052     4052              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add a new store to keep track of the information we have received about room
key bundles.
@richvdh richvdh force-pushed the rav/history_sharing/indexeddb_support branch from b4f4ec8 to 83ad34d Compare June 24, 2025 12:22
@richvdh richvdh marked this pull request as ready for review June 25, 2025 07:50
@richvdh richvdh requested review from a team as code owners June 25, 2025 07:50
@richvdh richvdh requested review from Hywan and poljar and removed request for a team June 25, 2025 07:50
Comment on lines -15 to -17
//! Migration code that moves from inbound_group_sessions2 to
//! inbound_group_sessions3, shrinking the values stored in each record.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a driveby fix: this comment had been incorrectly c&ped from somewhere else

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@poljar poljar removed the request for review from Hywan June 25, 2025 08:26
@poljar poljar merged commit 0722ed9 into main Jun 25, 2025
51 checks passed
@poljar poljar deleted the rav/history_sharing/indexeddb_support branch June 25, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History sharing: support for indexeddb
2 participants