Skip to content

refactor(crypto): Provide a specific error type for to-device events from dehydrated devices #5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Jun 25, 2025

This will get more usage soon, when we add a variant for events with unverified senders.

Prep for #4147

@andybalaam andybalaam requested review from a team as code owners June 25, 2025 10:34
@andybalaam andybalaam requested review from poljar and removed request for a team June 25, 2025 10:34
@andybalaam andybalaam changed the title refactor(crypto): Provide a specific error type for to-device events … refactor(crypto): Provide a specific error type for to-device events from dehydrated devices Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (22c99f3) to head (ec7a04c).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-crypto/src/machine/mod.rs 71.42% 4 Missing ⚠️
...ates/matrix-sdk-crypto/src/machine/test_helpers.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5282      +/-   ##
==========================================
- Coverage   90.19%   90.19%   -0.01%     
==========================================
  Files         334      334              
  Lines      105136   105142       +6     
  Branches   105136   105142       +6     
==========================================
  Hits        94830    94830              
- Misses       6242     6248       +6     
  Partials     4064     4064              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible, the fact that we're not unwedging sessions from dehydrated devices anymore is a win as well.

…from dehydrated devices

This will get more usage soon, when we add a variant for events with
unverified senders.
@andybalaam andybalaam force-pushed the andybalaam/decrypt_to_device_event-return-error branch from 862ac4c to ec7a04c Compare June 25, 2025 10:52
@andybalaam andybalaam enabled auto-merge (rebase) June 25, 2025 10:52
@andybalaam andybalaam merged commit 3c1d0b3 into main Jun 25, 2025
44 checks passed
@andybalaam andybalaam deleted the andybalaam/decrypt_to_device_event-return-error branch June 25, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants